Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firewall Allowed for NetLB mixed protocol #2740

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Firewall Allowed for NetLB mixed protocol #2740

wants to merge 1 commit into from
+152 −8

Conversation

TortillaZHawaii
Copy link
Contributor

When specifying multi protocol service NetLB Controller needs to update firewall rules to allow traffic to flow on both TCP and UDP ports. This PR introduces firewalls.AllowedForService which adds that functionality, and invokes the function if the EnableL4MixedProtocol flag is enabled.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 18, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 18, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @TortillaZHawaii. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 18, 2024
@mmamczur
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 18, 2024
@TortillaZHawaii
Copy link
Contributor Author

/lint

k8s-ci-robot
k8s-ci-robot reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TortillaZHawaii: 1 warning.

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pkg/firewalls/allowed.go Show resolved Hide resolved
@TortillaZHawaii TortillaZHawaii force-pushed the dwysocki-netlb-mixed-firewall-allow branch from 2cc4fac to 305fdda Compare November 18, 2024 13:46
@TortillaZHawaii
Copy link
Contributor Author

/lint

k8s-ci-robot
k8s-ci-robot reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TortillaZHawaii: 0 warnings.

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@TortillaZHawaii
Copy link
Contributor Author

/assign @mmamczur

@TortillaZHawaii
Add firewalls.AllowedForService
01c2ee3 
When specifying multi protocol service NetLB Controller needs to update firewall rules to allow traffic to flow on both TCP and UDP ports. This commit introduces firewalls.AllowedForService which adds that functionality, and invokes the function if the EnableL4MixedProtocol flag is enabled.
@TortillaZHawaii TortillaZHawaii force-pushed the dwysocki-netlb-mixed-firewall-allow branch from 305fdda to 01c2ee3 Compare November 21, 2024 14:59
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TortillaZHawaii
Once this PR has been reviewed and has the lgtm label, please ask for approval from mmamczur. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k8s-ci-robot k8s-ci-robot k8s-ci-robot left review comments

@aojea aojea Awaiting requested review from aojea

@sawsa307 sawsa307 Awaiting requested review from sawsa307

@mmamczur mmamczur Awaiting requested review from mmamczur

Assignees

@mmamczur mmamczur

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TortillaZHawaii @k8s-ci-robot @mmamczur