Extend retrieve current NEG endpoints to also look for NEGs in non-default subnets. #2731
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
|
Thanks! Haven't checked the tests, but besides those, this one is looking relatively straightforward. |
* Remove NodeTopologyInformer from controller context hasSynced so it won't block controllers from starting up in case of the CRD or CR does not exist.
* Query Node Topology CR for the current set of NEGs in the cluster. * When ensureNetworkEndpointGroups(), ensure NEGs are properly provisioned in the non-default subnets as well.
sawsa307
force-pushed
the
extend-retrieve-ep
branch
from
824842c
to
ef83a05
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sawsa307 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -883,6 +954,18 @@ func (s *transactionSyncer) computeEPSStaleness(endpointSlices []*discovery.Endp | |||
| } | |||
| } | |||
|
|
|||
| func (s *transactionSyncer) getNonDefaultSubnetName(subnet string) (string, error) { | |||
There was a problem hiding this comment.
this must be able to detect if it's running for L4 or L7 NEG and use the appropriate namer
There was a problem hiding this comment.
Ahh I see, we can probably check the NEG type and use the correct namer(namer/l4namer). Both of them are available to NEG controller. Thanks for catching this!
There was a problem hiding this comment.
Thanks for catching this!
sawsa307
force-pushed
the
extend-retrieve-ep
branch
from
ef83a05
to
5ae30eb
Compare
k8s-ci-robot
added
the
do-not-merge/work-in-progress
sawsa307
force-pushed
the
extend-retrieve-ep
branch
from
5ae30eb
to
8847eff
Compare
sawsa307
force-pushed
the
extend-retrieve-ep
branch
from
8847eff
to
2b8e5c7
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
/assign @gauravkghildiyal