-
Notifications
You must be signed in to change notification settings - Fork 1.6k
KEP-5598: Opportunistic batching #5599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
Welcome @bwsalmon! |
|
Hi @bwsalmon. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@bwsalmon - please sign the CLA (and I'm happy to take the production readiness approval for it) |
Cool. I tried to but it forwarded me to some Google reps to sign it... I sent the request but haven't heard back. Maybe I did it wrong? |
|
/cc @sanposhiho @macsko |
|
/label lead-opted-in |
Co-authored-by: Kensei Nakada <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current approach looks good to me
Co-authored-by: Maciej Skoczeń <[email protected]>
Co-authored-by: Maciej Skoczeń <[email protected]>
|
This looks good to me (both the core proposal and the PRR part) now. /approve PRR |
|
The proposed approach LGTM. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bwsalmon, sanposhiho, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
/unhold |
Uh oh!
There was an error while loading. Please reload this page.