Skip to content

Conversation

@bwsalmon
Copy link
Contributor

@bwsalmon bwsalmon commented Oct 1, 2025

  • One-line PR description: First version of the KEP for opportunistic batching
  • Other comments:

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 1, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 1, 2025
@k8s-ci-robot k8s-ci-robot requested a review from dom4ha October 1, 2025 23:11
@k8s-ci-robot
Copy link
Contributor

Welcome @bwsalmon!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested a review from macsko October 1, 2025 23:11
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 1, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @bwsalmon. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 1, 2025
@helayoty helayoty moved this to Needs Review in SIG Scheduling Oct 2, 2025
@wojtek-t
Copy link
Member

wojtek-t commented Oct 3, 2025

@bwsalmon - please sign the CLA

(and I'm happy to take the production readiness approval for it)

@wojtek-t wojtek-t self-assigned this Oct 3, 2025
@bwsalmon
Copy link
Contributor Author

bwsalmon commented Oct 3, 2025

@bwsalmon - please sign the CLA

(and I'm happy to take the production readiness approval for it)

Cool. I tried to but it forwarded me to some Google reps to sign it... I sent the request but haven't heard back. Maybe I did it wrong?

@dom4ha
Copy link
Member

dom4ha commented Oct 6, 2025

/cc @sanposhiho @macsko

@dom4ha
Copy link
Member

dom4ha commented Oct 6, 2025

/label lead-opted-in
/milestone v1.35

@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Oct 6, 2025
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Oct 6, 2025
@helayoty helayoty moved this from Needs Review to In Progress in SIG Scheduling Oct 7, 2025
bwsalmon and others added 2 commits October 16, 2025 06:08
Copy link
Member

@macsko macsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current approach looks good to me

@wojtek-t
Copy link
Member

This looks good to me (both the core proposal and the PRR part) now.

/approve PRR

@dom4ha
Copy link
Member

dom4ha commented Oct 16, 2025

The proposed approach LGTM. Thanks!

Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bwsalmon, sanposhiho, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2025
@sanposhiho
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot merged commit 061e620 into kubernetes:master Oct 16, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in SIG Scheduling Oct 16, 2025
@sanposhiho
Copy link
Member

/unhold
(I just wanted to do a squash merge.. anyway)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lead-opted-in Denotes that an issue has been opted in to a release lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants