Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3857: Recursive Read-only (RRO) mounts: promote to GA #5157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KEP-3857: Recursive Read-only (RRO) mounts: promote to GA #5157

wants to merge 1 commit into from
+46 −16

Conversation

AkihiroSuda
Copy link
Member

  • One-line PR description: KEP-3857: Recursive Read-only (RRO) mounts: promote to GA
  • Other comments: NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 10, 2025
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 10, 2025
@AkihiroSuda AkihiroSuda mentioned this pull request Feb 10, 2025
Open
19 tasks
@AkihiroSuda
Copy link
Member Author

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/enhancements/5157/pull-enhancements-test/1888853249730023424

getting PRR approver for stable stage: the selected PRR milestone stage is not populated

soltysh
soltysh reviewed Feb 10, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits

keps/prod-readiness/sig-node/3857.yaml Show resolved Hide resolved
keps/sig-node/3857-rro-mounts/README.md Show resolved Hide resolved
keps/sig-node/3857-rro-mounts/README.md Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AkihiroSuda, mrunalp
Once this PR has been reviewed and has the lgtm label, please assign wojtek-t for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh left review comments

@kannon92 kannon92 kannon92 left review comments

@sftim sftim sftim left review comments

@mrunalp mrunalp mrunalp approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AkihiroSuda @k8s-ci-robot @mrunalp @soltysh @kannon92 @sftim