Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-2831: update kubelet tracing KEP to target GA in 1.33 #5134

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Feb 5, 2025

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 5, 2025
@dashpole dashpole force-pushed the update_kubelet_tracing branch 2 times, most recently from 329a3f0 to f2dbbce Compare February 5, 2025 20:19
@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2025
@dashpole
Copy link
Contributor Author

dashpole commented Feb 5, 2025

/assign @wojtek-t

@dashpole
Copy link
Contributor Author

dashpole commented Feb 5, 2025

Sorry for the late review request @wojtek-t

Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc

please @dashpole make sure to use the latest KEP template. The template is periodically updated and if the lastest update of the KEP was more than a couple cycles old there can be some changes to be made

@k8s-ci-robot k8s-ci-robot requested a review from ffromani February 6, 2025 17:05
Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor comments but don't want them to slip through the cracks:

Some sections in the PRR Questionaire are still marked as TBD (e.g, Are there any missing metrics that would be useful to have to improve observability ).

Also, I see there are plans to add metrics but metric section is TBD in kep.yaml.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 7, 2025
@dashpole
Copy link
Contributor Author

dashpole commented Feb 7, 2025

@swatisehgal @ffromani I updated the KEP to use the new template.

We are blocked adding metrics by work in upstream OpenTelemetry. But traces are themselves an observability signal, and can be used to see if the feature is working properly. I don't think metrics should block the GA of this feature

@dashpole dashpole force-pushed the update_kubelet_tracing branch 2 times, most recently from 80404ee to 810ca4b Compare February 7, 2025 21:33
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments - other than that LGTM.
But please work on having SIG approval first.

Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty much LGTM from sig-node, few thoughts inline

@dashpole dashpole force-pushed the update_kubelet_tracing branch from 810ca4b to 51ee9a7 Compare February 10, 2025 21:37
@rexagod
Copy link
Member

rexagod commented Feb 10, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2025
@pacoxu pacoxu mentioned this pull request Feb 11, 2025
12 tasks
@ffromani
Copy link
Contributor

LGTM also from sig-node. I think pending open points are on PRR side.

@dashpole dashpole force-pushed the update_kubelet_tracing branch from 51ee9a7 to 446aa3e Compare February 12, 2025 20:35
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 12, 2025
@richabanker
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2025
@wojtek-t wojtek-t added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 13, 2025
@wojtek-t
Copy link
Member

/lgtm
/approve PRR

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2025
@k8s-ci-robot k8s-ci-robot merged commit 715bda6 into kubernetes:master Feb 13, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Feb 13, 2025
@dashpole dashpole deleted the update_kubelet_tracing branch February 13, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants