Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5100: Adding retroactive KEP for WinDSR and WinOverlay #5112

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

5100: Adding retroactive KEP for WinDSR and WinOverlay #5112

wants to merge 8 commits into from
+1,027 −0

Conversation

marosset
Copy link
Contributor

  • One-line PR description: Retroactive KEP for WinDSR and WinOverlay
  • Other comments:

/milestone v1.33
/sig windows network
/wip

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 30, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 30, 2025
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 30, 2025
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jan 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marosset
Once this PR has been reviewed and has the lgtm label, please assign jpbetz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 30, 2025
@marosset marosset changed the title WIP: 5100: Adding retroactive KEP for WinDSR and WinOverlay 5100: Adding retroactive KEP for WinDSR and WinOverlay Feb 3, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2025
@marosset marosset mentioned this pull request Feb 3, 2025
Open
5 tasks
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 4, 2025
soltysh
soltysh reviewed Feb 10, 2025
View reviewed changes
keps/prod-readiness/sig-windows/5100.yaml Outdated
alpha:
approver: ""
beta:
approver: "@TBD"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put my name here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soltysh - I'll add you as the alpha approver too since these features never had a PRR review for the alpha implementation?

keps/sig-windows/5100-windows-dsr-and-overlay-support/README.md
- [ ] (R) Production readiness review approved
- [ ] "Implementation History" section is up-to-date for milestone
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
- [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: make sure to check appropriate boxes.

keps/sig-windows/5100-windows-dsr-and-overlay-support/README.md Outdated Show resolved Hide resolved
keps/sig-windows/5100-windows-dsr-and-overlay-support/README.md
extending the production code to implement this enhancement.
-->

Unit tests validating overlay networking behavior exist at https://github.com/kubernetes/kubernetes/blob/master/pkg/proxy/winkernel/proxier_test.go but must run on Windows machines so coverage is not reported in ci-kubernetes-coverage-unit.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but I assume you might run this locally and provide these values in this document.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

keps/sig-windows/5100-windows-dsr-and-overlay-support/README.md Outdated Show resolved Hide resolved
keps/sig-windows/5100-windows-dsr-and-overlay-support/README.md Outdated Show resolved Hide resolved
keps/sig-windows/5100-windows-dsr-and-overlay-support/README.md
are missing a bunch of machinery and tooling and can't do that now.
-->

For DSR support yes, manual verification was done to ensure that DSR can be enabled and disabled on a node.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please describe the manual testing performed, see https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/3850-backoff-limits-per-index-for-indexed-jobs/README.md#were-upgrade-and-rollback-tested-was-the-upgrade-downgrade-upgrade-path-tested as an example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated - PTAL

keps/sig-windows/5100-windows-dsr-and-overlay-support/README.md

No

### Troubleshooting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is missing.

keps/sig-windows/5100-windows-dsr-and-overlay-support/README.md

###### What steps should be taken if SLOs are not being met to determine the problem?

## Implementation History
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And so is this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

keps/sig-windows/5100-windows-dsr-and-overlay-support/README.md
- when the KEP was retired or superseded
-->

## Drawbacks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh left review comments

@jsturtevant jsturtevant jsturtevant left review comments

@aravindhp aravindhp Awaiting requested review from aravindhp

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees

@jsturtevant jsturtevant

@MikeZappa87 MikeZappa87

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
5 participants
@marosset @k8s-ci-robot @soltysh @jsturtevant @MikeZappa87