-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: workload charts are black for certain languages #9067
base: master
Are you sure you want to change the base?
fix: workload charts are black for certain languages #9067
Conversation
Welcome @HanNguyen-dev! |
Nice fix @HanNguyen-dev, thanks. LFT it being merged ! |
I agree , it is a nice fix. It will Help to fix the issue in all languages at once. |
@gdelvallez1: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gdelvallez1, HanNguyen-dev The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
For certain languages such as KR and FR, the workload charts are black.
The current code is pulling out the translation for the different statuses by passing
Running
,Succeeded
, etc; just that there are different texts (3) starting withRunning
,Succeeded
, etc.The code change passes in an
empty string
forplaceholder
to mimic how status label names were generated; thus the translated text will be a substring of the status label names.dashboard/modules/web/src/overview/helper.ts
Lines 30 to 34 in 5d6805d
closes #8898
closes #8753