Update steering readme #8463
Update steering readme #8463
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
Thank you! :) |
committee-steering/README.md
Outdated
| * Public Steering Committee Meeting: [first Wednesdays at 8:00 PT (Pacific Time)](https://bit.ly/k8s-steering-wd) (monthly). [Convert to your timezone](http://www.thetimezoneconverter.com/?t=8%3A00&tz=PT%20%28Pacific%20Time%29). | ||
| * [Meeting recordings](https://www.youtube.com/watch?v=YAzgJRQxsdc&list=PL69nYSiGNLP1yP1B_nd9-drjoxp0Q14qM). | ||
| *Joining the [mailing list](https://groups.google.com/a/kubernetes.io/g/steering) for the group will typically add invites for the following meetings to your calendar.* | ||
| * Private Steering Committee Meeting: [third Wednesdays at 8:00 PT (Pacific Time)]() (monthly). [Convert to your timezone](http://www.thetimezoneconverter.com/?t=8%3A00&tz=PT%20%28Pacific%20Time%29). |
There was a problem hiding this comment.
This renders as a link to this README.md itself, which is a bit odd. Perhaps link to https://github.com/kubernetes/steering/blob/main/README.md#meetings which explains that we have a private meeting?
There was a problem hiding this comment.
We've had a link to our public agenda here, previously, but that wasn't useful. I missed we always generate this link. But I agree that using just meetings as a stop-gap here is probably the best option.
There was a problem hiding this comment.
Clicking on the link still takes me back to the same page. Wouldn't https://github.com/kubernetes/steering/blob/main/README.md#meetings (different page!) be better?
There was a problem hiding this comment.
Why a different page? I did use current on-purpose. Alternatively I'm inclined to let the url component be empty and not render that a link, what do you think of that kind of approach?
There was a problem hiding this comment.
Because I clicked the link and was confused when nothing changed.
If you leave the url empty, it is still rendered as a link.
There was a problem hiding this comment.
If we can change the page generator to not render as a link when no URL is provided, then that probably would be best.
There was a problem hiding this comment.
I still think that a link which links to itself is odd, but let's not block the PR on that.
/lgtm
There was a problem hiding this comment.
I still think that a link which links to itself is odd, but let's not block the PR on that.
/lgtm
I'll work on a followup to allow that url just be empty, which will be the best outcome.
This updates: - the private meeting time - the link to the public call, adds agenda link, and fixes YT playlist - drops agenda and call link from private call. Signed-off-by: Maciej Szulik <[email protected]>
|
@pohly this should be fixed now. |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, justaugustus, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Which issue(s) this PR fixes:
This updates:
Kudos to @palnabarun for pointing it out 😄
@kubernetes/steering-committee