Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove inaccurate representation of subprojects #8179

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

BenTheElder
Copy link
Member

Work groups CANNOT sponsor subprojects, only suggest and participate in them. work groups are discussion groups for interests that potentially cross sigs.

Also, subprojects are tracked in sigs.yaml in a standardized format with specific metadata required.

Which issue(s) this PR fixes:

Fixes #

/assign @kubernetes/steering-committee

FYI @ArangoGutierrez @Jeffwan @SergeyKanzhelev @terrytangyuan

work groups CANNOT sponsor subprojects, only suggest and participate in them. work groups are discussion groups for interests that potentially cross sigs.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. wg/serving Categorizes an issue or PR as relevant to WG Serving. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 21, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 21, 2024
Copy link
Member Author

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -51,12 +51,6 @@ The WG Serving will operate in several workstreams with different areas of focus
- [Orchestration](https://docs.google.com/document/d/1hbEx3ZEqdXCqWH9RL3uy9FIy35B8pFJ5KiK3HsOz2FE/edit?usp=sharing)
- [DRA](https://github.com/kubernetes/community/tree/master/wg-device-management)

## Sponsored Subprojects

* [LLM Instance Gateway](https://github.com/kubernetes-sigs/llm-instance-gateway)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is sponsored by SIG Apps and already listed there. It may be sponsored by SIG Network instead in the future.

## Sponsored Subprojects

* [LLM Instance Gateway](https://github.com/kubernetes-sigs/llm-instance-gateway)
* [Serving Catalog](https://github.com/kubernetes-sigs/wg-serving/tree/main/serving-catalog)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a subproject, it is at most some experimental code.

If it were a subproject, it would need to be sponsored through the relevant SIG (Probably Apps?), who already has a charter encompassing this and has the discretion over project lifecycle.

Please do not advertise subprojects without going through the processes we have in place for managing projects and avoiding conflicting ownership.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rephrase this to be something like "Relevant projects"? The main idea is just to get more visibility for the projects we are working on.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really shouldn't be advertising a "Serving catalog" project that no one approved as a project to be hosted in the organization.

As for LLM Instance Gateway, it is advertised as a SIG Apps project for now, and we have a pretty standardized format for the SIG/WG documentation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can revisit a way to link WGs to subprojects they may be participating in, but currently that's supposed to be documented by way of the SIGs they are involved with / sponsored by, and these are pretty clearly within the scope of SIG Net and SIG Apps.

I have previously requested this correction in kubernetes-sigs/llm-instance-gateway#41, that repo also needs updating to clarify still, as it has similarly inaccurate language in the README.

To be clear: I hope you all succeed in your efforts, but we have the governance for a reason, to avoid arbitrarily hosting projects under the kubernetes umbrella and to avoid conflicts between overlapping groups.

Work Groups are easy to create because they allow creating a place to focus on something across or within the SIGs without hammering out an ironclad, conflict-free charter. But that also means that the projects they spawn roll up to one of the SIGs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification!

@terrytangyuan
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2e73f27 into kubernetes:master Nov 22, 2024
3 checks passed
@BenTheElder BenTheElder deleted the wg-no-sponsor branch November 22, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. wg/serving Categorizes an issue or PR as relevant to WG Serving.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants