-
Notifications
You must be signed in to change notification settings - Fork 4.2k
cluster-autoscaler/cloudstack: Add project-id support for multi-project environments #8654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ct environments This commit adds support for the optional project-id parameter in CloudStack cloud provider configuration. This is required for clusters running in CloudStack projects, as the listKubernetesClusters API returns empty results when querying by cluster ID without the projectid parameter in multi-project environments. Changes: - Add ProjectID field to service.Config struct - Pass ProjectID from cloud-config to service configuration - Include projectid parameter in all CKS API calls when configured: * listKubernetesClusters (GetClusterDetails) * scaleKubernetesCluster (ScaleCluster and RemoveNodesFromCluster) - Update README.md to document the optional project-id parameter The project-id parameter is optional and backwards compatible. If not specified, the API uses the default project associated with the credentials.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mperea The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @mperea. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/label area/cloudstack |
@jackfrancis: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
This commit adds support for the optional project-id parameter in CloudStack cloud provider configuration. This is required for clusters running in CloudStack projects, as the listKubernetesClusters API returns empty results when querying by cluster ID without the projectid parameter in multi-project environments.
Changes:
The project-id parameter is optional and backwards compatible. If not specified, the API uses the default project associated with the credentials.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes a critical issue where the cluster-autoscaler fails to work with Kubernetes clusters running in CloudStack projects.
Problem: The autoscaler currently ignores the
project-id
configured in the cloud-config and doesn't include theprojectid
parameter in API calls to CloudStack. This causes thelistKubernetesClusters
API to return empty results even when the cluster exists, resulting in continuous errors:Solution: This PR adds support for the optional
project-id
parameter by:ProjectID
field to the service configurationprojectid
parameter in all CloudStack API calls when configuredWhich issue(s) this PR fixes:
Special notes for your reviewer:
project-id
parameter is optional and maintains full backward compatibilityTesting performed:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: