Skip to content

Conversation

jackfrancis
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

@omerap12 noticed that ./hack/update-gofmt.sh produces a diff for various files in the AWS cloudprovider area. This PR commits those changes.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area labels Oct 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-area labels Oct 7, 2025
@jackfrancis
Copy link
Contributor Author

/assign @x13n

@x13n
Copy link
Member

x13n commented Oct 10, 2025

I'm not very familiar with aws cloudprovider, @gjtempleton is aws-sdk-go code ok to modify in place?

@jackfrancis
Copy link
Contributor Author

@x13n good point, I had assumed this is code that is manually maintained by the CA provider because it's not vendored, but definitely worth clarifying

can @drmorr0 @Jeffwan @jaypipes weigh in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants