Trigger an explicit scale up error when expander filters out all scale-up options #7512
+20
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ons.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Cluster autoscaler will silently fail the scale-up in case expander was not able to pick the best option, this change adds logs to capture this behavior as well as changes the status of the scale up from ScaleUpNoOptionsAvailable to ScaleUpError
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This should not affect expanders as BestOption semantics tells us that this interface is supposed to pick the best option out of available ones and not to filter them out completely even if any are available
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: