-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Info log string concatenation in authmanager.go #3111
base: master
Are you sure you want to change the base?
Conversation
Fixed a string concatenation issue resulting in and incorrect debug log string.
The committers listed above are authorized under a signed CLA. |
Welcome @scranshoff! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: scranshoff The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @scranshoff. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Fixes a string concatenation issue resulting in an incorrect Info log string in authmanager.go, see #3110
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #fixes issue 3110
Testing done:
Result:
Info log string no contains the variables at the correct locations.
Special notes for your reviewer:
This is just a Cosmetic change to the code as it annoyed me, no functional impact .
Release note: