Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encryption of block volumes using EncryptionClasses #3106

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Encryption of block volumes using EncryptionClasses #3106

wants to merge 5 commits into from
+2,825 −67

Conversation

nikolay-andreev
Copy link

@nikolay-andreev nikolay-andreev commented Nov 14, 2024 •
edited by divyenpatel
Loading

What this PR does / why we need it:
Implement encryption of block volumes using EncryptionClass associated with PVC

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:
GINKGO_FOCUS=encryption make test-e2e

  • Verify PVC is encrypted with EC.
  • Verify PVC is encrypted with the default EC.
  • Verify PVC is recrypted when setting new EC.
  • Verify PVC is recrypted when associated EC has its key rotated.
  • Verify PVC creation fails when associated with EC and SC not supporting encryption.
  • Verify VM encrypted with EC, PVC is not encrypted.
  • Verify VM and PVC are encrypted with EC.
  • Verify VM and attached PVC are encrypted with default EncryptionClass.
  • Verify VM and attached PVC are encrypted with different keys.
  • Verify VM and attached PVC are encrypted with EncryptionClass, key is rotated.

Special notes for your reviewer:

Release note:

Encryption of block volumes using EncryptionClasses

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 14, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 14, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @nikolay-andreev!

It looks like this is your first PR to kubernetes-sigs/vsphere-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/vsphere-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @nikolay-andreev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 14, 2024
@divyenpatel
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2024
divyenpatel
divyenpatel requested changes Nov 14, 2024
View reviewed changes
cmd/syncer/main.go Outdated Show resolved Hide resolved
cmd/syncer/main.go Outdated Show resolved Hide resolved
go.mod
@@ -22,7 +22,8 @@ require (
github.com/prometheus/client_golang v1.18.0
github.com/stretchr/testify v1.9.0
github.com/vmware-tanzu/vm-operator/api v1.8.2
github.com/vmware/govmomi v0.46.0
github.com/vmware-tanzu/vm-operator/external/byok v0.0.0-20241108223224-20f977201370
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to make sure we have release tag for github.com/vmware-tanzu/vm-operator having this dependency. Do we have a plan to cut release for vm-operator for this change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akutz can we create a tag in vm-operator for BYOK changes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For which? One? Both? If the BYOK stuff is locked, then we can possibly cut a tag for it. But the VM Op API is not necessarily locked yet, so it's premature to cut a tag for it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can merge it now with this commit reference, but before release, we can re-visit this and update go.mod file.

go.mod Outdated Show resolved Hide resolved
pkg/common/cns-lib/crypto/client.go Show resolved Hide resolved
pkg/syncer/byokoperator/vcenter/provider.go Outdated Show resolved Hide resolved
tests/e2e/crypto.go Outdated Show resolved Hide resolved
pkg/syncer/byokoperator/vcenter/provider.go Outdated Show resolved Hide resolved
pkg/syncer/byokoperator/vcenter/provider.go Outdated Show resolved Hide resolved
pkg/csi/service/common/constants.go Outdated Show resolved Hide resolved
@divyenpatel
Copy link
Member

@nikolay-andreev can you also fix linter issues on the PR?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 20, 2024
@nikolay-andreev nikolay-andreev force-pushed the feature/block-volume-encryption branch 2 times, most recently from 622a43b to f61df97 Compare November 20, 2024 17:29
@nikolay-andreev nikolay-andreev force-pushed the feature/block-volume-encryption branch 2 times, most recently from 22139e6 to e079908 Compare November 20, 2024 21:23
divyenpatel
divyenpatel approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@divyenpatel divyenpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyenpatel, nikolay-andreev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2024
@divyenpatel
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2024
@divyenpatel
Copy link
Member

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adikul30 adikul30 adikul30 left review comments

@akutz akutz akutz left review comments

@dougm dougm dougm left review comments

@divyenpatel divyenpatel divyenpatel approved these changes

@kavyashree-r kavyashree-r Awaiting requested review from kavyashree-r

@SandeepPissay SandeepPissay Awaiting requested review from SandeepPissay

Assignees

@divyenpatel divyenpatel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nikolay-andreev @k8s-ci-robot @divyenpatel @dougm @akutz @adikul30