Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update interval to 10min for storage quota periodic sync #3081

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update interval to 10min for storage quota periodic sync #3081

wants to merge 1 commit into from
+8 −2

Conversation

nikhilbarge
Copy link
Contributor

@nikhilbarge nikhilbarge commented Oct 16, 2024 •
edited
Loading

What this PR does / why we need it:
Update time interval to 10min and added provision to disable periodic sync for storage quota.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:

Special notes for your reviewer:

Release note:

Update interval to 10min for storage quota periodic sync

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 16, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @nikhilbarge. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2024
@nikhilbarge nikhilbarge force-pushed the update_interval_for_periodic-sq-sync branch from fbac27c to 6fbdf59 Compare October 16, 2024 08:42
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2024
@vdkotkar
Copy link
Contributor

For now let's go ahead and make default periodic sync interval to 10 min, if we see that it is increasing the resource's consumption and hampering performance, then we will go back to 30 min.

@vdkotkar
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nikhilbarge, vdkotkar
Once this PR has been reviewed and has the lgtm label, please assign gohilankit for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akankshapanse
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 18, 2024
vdkotkar
vdkotkar reviewed Oct 22, 2024
View reviewed changes
manifests/supervisorcluster/1.28/cns-csi.yaml
@@ -377,6 +377,7 @@ spec:
- "--leader-election-lease-duration=120s"
- "--leader-election-renew-deadline=60s"
- "--leader-election-retry-period=30s"
- "--storagequota-sync-interval=10m"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add RBAC changes as well to 1.28 and 1.29 files

@akankshapanse akankshapanse mentioned this pull request Oct 22, 2024
Merged
@vdkotkar
Copy link
Contributor

These changes are being done thorugh PR #3086, please close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdkotkar vdkotkar vdkotkar left review comments

@adikul30 adikul30 Awaiting requested review from adikul30

@shalini-b shalini-b Awaiting requested review from shalini-b

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikhilbarge @k8s-ci-robot @vdkotkar @akankshapanse