[WIP] Add log handler for writing errors to file #9
+63
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
benjaminapetersen
changed the title
k8s-ci-robot
added
do-not-merge/work-in-progress
Author
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
knabben
reviewed
Nov 16, 2025
| } | ||
|
|
||
| // initLog creates a new log file with a timestamped name each run. | ||
| func initLog() (*os.File, error) { |
Member
There was a problem hiding this comment.
we could add as a flag, --log-file ./ -- otherwise it goes to stdout, wdyt?
k8s-ci-robot
added
the
needs-rebase
Contributor
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #7
A quick prototype PR to get a conversation started.
Creates a
/logsdir on the file system and a new log file on each run:Contents of log file are something like:
Currently the log message along the footer of SignalHound can be truncated for the same error message:
@knabben