Skip to content

[WIP] Add GITHUB_ISSUE_EXISTS to GitHub tab state #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benjaminapetersen wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

[WIP] Add GITHUB_ISSUE_EXISTS to GitHub tab state #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion internal/tui/panel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@

// GitHub panel rendering
setPanelDefaultStyle(githubPanel.Box)
githubPanel.SetTitle(formatTitle("Github Issue"))
githubPanel.SetTitle(formatTitle("Github Issue Exists!"))
githubPanel.SetWrap(true)

// Final position bottom panel for information
Expand Down Expand Up @@ -177,10 +177,15 @@
}

// pick the correct template by failure status
templateFile, prefixTitle := "template/flake.tmpl", "Flaking Test"

Check failure on line 180 in internal/tui/panel.go

View workflow job for this annotation

GitHub Actions / Run on Ubuntu 

ineffectual assignment to templateFile (ineffassign)
if tab.TabState == v1alpha1.FAILING_STATUS {
templateFile, prefixTitle = "template/failure.tmpl", "Failing Test"

Check failure on line 182 in internal/tui/panel.go

View workflow job for this annotation

GitHub Actions / Run on Ubuntu 

ineffectual assignment to templateFile (ineffassign)
}
// TODO: add status of "GITHUB_ISSUE_EXISTS" and load different template
// if tab.TabState == v1alpha1.GITHUB_ISSUE_EXISTS_STATUS {
templateFile, prefixTitle = "template/github-issue-exists.tmpl", "GitHub Issue Exists"
// }

template, err := renderTemplate(issue, templateFile)
if err != nil {
position.SetText(fmt.Sprintf("[red]error: %v", err.Error()))
Expand Down
8 changes: 8 additions & 0 deletions internal/tui/template/github-issue-exists.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
### GitHub Issue Title

ClusterLoaderV2.access-tokens: [step: 02] Creating ServiceAccounts

### GitHub Issue URL

https://testgrid.k8s.io/sig-release-master-informing#ec2-master-scale-performance

Loading