Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect newline in command examples in command-help #346

Merged

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Dec 17, 2024

Currently, the command-help page renders multiline command examples (the
only example I've seen is for /release-note-edit) on one line, which is
confusing for users.

Change the style to respect newline in the source.

Link: https://developer.mozilla.org/en-US/docs/Web/CSS/white-space

Before:
image

After:
image

Currently, the command-help page renders multiline command examples (the
only example I've seen is for /release-note-edit) on one line, which is
confusing for users.

Change the style to respect newline in the source.

Link: https://developer.mozilla.org/en-US/docs/Web/CSS/white-space
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 17, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 17, 2024
Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for k8s-prow ready!

Name Link
🔨 Latest commit 5826c78
🔍 Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/67613d26b59b360008168f08
😎 Deploy Preview https://deploy-preview-346--k8s-prow.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@VannTen
Copy link
Contributor Author

VannTen commented Dec 17, 2024 via email

@VannTen
Copy link
Contributor Author

VannTen commented Dec 17, 2024

Failing test is an instance of #309

@matthyx
Copy link
Contributor

matthyx commented Dec 17, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matthyx, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit ace5c41 into kubernetes-sigs:main Dec 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants