Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: Move tools into own go.mod #1321

Merged
merged 1 commit into from
Sep 11, 2023
Merged

go.mod: Move tools into own go.mod #1321

merged 1 commit into from
Sep 11, 2023

Conversation

mrueg
Copy link
Member

@mrueg mrueg commented Aug 29, 2023

What this PR does / why we need it:
Move auxiliary tools like mdtoc to its own go.mod

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 29, 2023
@mrueg mrueg force-pushed the own-go-mod-for-scripts branch from 795bf91 to 4a5cc1a Compare August 29, 2023 14:26
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 29, 2023
@mrueg
Copy link
Member Author

mrueg commented Aug 29, 2023

/retest

1 similar comment
@mrueg
Copy link
Member Author

mrueg commented Aug 29, 2023

/retest

@mrueg mrueg force-pushed the own-go-mod-for-scripts branch 2 times, most recently from 6cc04c5 to 1b22f1f Compare August 29, 2023 14:48
@dgrisonnet
Copy link
Member

/triage accepted
/assign @dgrisonnet @serathius

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 7, 2023
@serathius
Copy link
Contributor

/retest

yangjunmyfm192085
yangjunmyfm192085 reviewed Sep 8, 2023
View reviewed changes
Copy link
Contributor

@yangjunmyfm192085 yangjunmyfm192085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@serathius
Copy link
Contributor

Please rebase on master as it includes fix for pull-metrics-test-version #1328

@mrueg mrueg force-pushed the own-go-mod-for-scripts branch from 1b22f1f to d1b5cef Compare September 11, 2023 10:11
@serathius
Copy link
Contributor

/lgtm
/approve

Two follow ups:

  • both /go.mod and /scripts/go.mod reference k8s.io/kube-openapi, how do we make sure they are in sync?
  • We should have dependabot setup for /scripts/go.mod

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrueg, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 68557ae into kubernetes-sigs:master Sep 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangjunmyfm192085 yangjunmyfm192085 yangjunmyfm192085 left review comments

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

Assignees

@serathius serathius

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrueg @dgrisonnet @serathius @k8s-ci-robot @yangjunmyfm192085