Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace which with command -v #1320

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Replace which with command -v #1320

merged 1 commit into from
Sep 11, 2023

Conversation

mrueg
Copy link
Member

@mrueg mrueg commented Aug 29, 2023

What this PR does / why we need it:
command -v is POSIX shell and doesn't require an additional binary
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 29, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 29, 2023
dgrisonnet
dgrisonnet reviewed Aug 29, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
dgrisonnet
dgrisonnet approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @serathius

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2023
@serathius
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2023
@serathius
Copy link
Contributor

/retest

2 similar comments
@serathius
Copy link
Contributor

/retest

@dgrisonnet
Copy link
Member

/retest

@dgrisonnet
Copy link
Member

/lgtm

@dgrisonnet
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2023
@mrueg
Copy link
Member Author

mrueg commented Aug 30, 2023

Not sure why this one fails as the changes seem unrelated. I updated the build image in cloudbuild.yaml (which was from 2021) to see if that improves it.

@mrueg
Copy link
Member Author

mrueg commented Aug 30, 2023

/retest

1 similar comment
@mrueg
Copy link
Member Author

mrueg commented Aug 31, 2023

/retest

@dgrisonnet
Copy link
Member

The CI is flaky at the moment, you shouldn't need to change the cloudbuild

@mrueg
Copy link
Member Author

mrueg commented Sep 1, 2023

I dropped the cloudbuild image changes
/retest

@serathius
Copy link
Contributor

/retest

1 similar comment
@mrueg
Copy link
Member Author

mrueg commented Sep 5, 2023

/retest

@dgrisonnet
Copy link
Member

/lgtm
/triage accepted
/retest

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 7, 2023
@mrueg
Replace which with command -v
be4fe17 
command -v is POSIX shell and doesn't require an additional binary
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2023
serathius
serathius reviewed Sep 11, 2023
View reviewed changes
Makefile Outdated
@@ -72,7 +72,7 @@ CONTAINER_ARCH_TARGETS=$(addprefix container-,$(ALL_ARCHITECTURES))
container:
# Pull base image explicitly. Keep in sync with Dockerfile, otherwise
# GCB builds will start failing.
docker pull golang:1.19.8
docker pull golang:1.20.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove this unrelated change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. :)

@serathius
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, mrueg, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 797ef17 into kubernetes-sigs:master Sep 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius left review comments

@dgrisonnet dgrisonnet dgrisonnet approved these changes

@yangjunmyfm192085 yangjunmyfm192085 Awaiting requested review from yangjunmyfm192085

Assignees

@serathius serathius

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrueg @serathius @dgrisonnet @k8s-ci-robot