Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kwokctl] Support for all about nerdctl as runtime #997

Merged
merged 1 commit into from
May 16, 2024

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Mar 15, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[kwokctl] Support for all about nerdctl as runtime

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 15, 2024
Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit a494ffa
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/6645cb1e0e13750007642e07

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 15, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 15, 2024
@wzshiming wzshiming force-pushed the feat/kind-nerdctl branch 4 times, most recently from 7957923 to 3ebe3eb Compare April 8, 2024 07:54
@wzshiming wzshiming force-pushed the feat/kind-nerdctl branch 9 times, most recently from ae6c172 to c953f33 Compare May 16, 2024 06:09
@wzshiming wzshiming changed the title [kwokctl] Support kind-nerdctl as runtime [kwokctl] Support for all about nerdctl as runtime May 16, 2024
@wzshiming wzshiming force-pushed the feat/kind-nerdctl branch 2 times, most recently from 2388617 to 1e1dbdc Compare May 16, 2024 06:46
@wzshiming wzshiming force-pushed the feat/kind-nerdctl branch 2 times, most recently from 53c9281 to a494ffa Compare May 16, 2024 09:00
@wzshiming wzshiming merged commit ee02ea5 into kubernetes-sigs:main May 16, 2024
41 of 44 checks passed
@wzshiming wzshiming deleted the feat/kind-nerdctl branch May 16, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants