Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kwokctl] Fix disable kube-controller-manager on kind runtime #1232

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Sep 25, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[kwokctl] Fix disable kube-controller-manager on kind runtime

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Sep 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 25, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 25, 2024
Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit 74ce806
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/66f38bb12c90510008216770

@wzshiming wzshiming changed the title Fix disable kube-controller-manager on kind runtime [kwokctl] Fix disable kube-controller-manager on kind runtime Sep 25, 2024
@wzshiming wzshiming merged commit b170654 into kubernetes-sigs:main Sep 25, 2024
32 of 33 checks passed
@wzshiming wzshiming deleted the fix/kind-disable-kube-controller-manager branch September 25, 2024 05:16
@wzshiming
Copy link
Member Author

/cherrypick release-0.6

@k8s-infra-cherrypick-robot

@wzshiming: new pull request created: #1233

In response to this:

/cherrypick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants