Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for default environment under cel package #1119

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Manoramsharma
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Added unit tests for default and environment under cel package

Which issue(s) this PR fixes:

Fixes #

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Manoramsharma
Once this PR has been reviewed and has the lgtm label, please assign yibozhuang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 28, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 28, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Manoramsharma. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 28, 2024
Copy link

netlify bot commented May 28, 2024

Deploy Preview for k8s-kwok ready!

Name Link
🔨 Latest commit 6af6e7b
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/6660400318baea00086787eb
😎 Deploy Preview https://deploy-preview-1119--k8s-kwok.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Manoramsharma
Copy link
Contributor Author

@wzshiming I observed same check for binary runtime failed with an error message this Test kwokctl/kwokctl_binary_benchmark failed. .

So I changed the default_test.go writing units tests by testify assert rule and made a final commit but again got this lint error which says

  Running [/home/runner/golangci-lint-1.58.2-linux-amd64/golangci-lint run  --timeout=30m --config=.golangci.yaml] in [/home/runner/work/kwok/kwok] ...
  Received 3446 of 3446 (100.0%), 0.0 MBs/sec
  level=warning msg="[config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`."
  level=error msg="Running error: context loading failed: no go files to analyze: running `go mod tidy` may solve the problem"

Note: I am working a fork which has latest changes from upstream/main . Looking forward for your guidance over this.

Thanks

Signed-off-by: Manoram Sharma <[email protected]>
Signed-off-by: Manoram Sharma <[email protected]>
@Manoramsharma
Copy link
Contributor Author

Test/ test-kwok-e2e check is working fine on my local system. Providing you the screenshot of the passing test below:
Screenshot 2024-06-05 at 4 42 12 PM

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants