Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an in-cluster example for error injection #1058

Merged
merged 1 commit into from
May 8, 2024
Merged

Add an in-cluster example for error injection #1058

merged 1 commit into from
May 8, 2024

Conversation

yuanchen8911
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds an example showing how to inject an error to an initContainer to simulate failure in a Kubernetes cluster.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 1, 2024
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label May 1, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 1, 2024
@netlify Netlify
Copy link

netlify bot commented May 1, 2024 •
edited
Loading

✅ Deploy Preview for k8s-kwok ready!

Name Link
🔨 Latest commit e21466e
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/663a8afa08986300080e45de
😎 Deploy Preview https://deploy-preview-1058--k8s-kwok.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yuanchen8911
Copy link
Member Author

/assign @wzshiming

@yuanchen8911
Copy link
Member Author

/retest

wzshiming
wzshiming reviewed May 7, 2024
View reviewed changes
Copy link
Member

@wzshiming wzshiming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be supplemented with docs for a more complete example?

site/content/en/docs/user/examples/injectfailure/virtual-gpu-node.yaml Outdated Show resolved Hide resolved
site/content/en/docs/user/examples/injectfailure/failed-pod.yaml Show resolved Hide resolved
site/content/en/docs/user/examples/injectfailure/init-container-error-injection.demo Outdated
Comment on lines 5 to 6
SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
WORK_DIR=$(cd ${SCRIPT_DIR}/../site/content/en/docs/user/examples/failureinjection/; pwd -P)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1066
I think it should be a builtin variable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll make a change after your PR is merged.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted and use the global environment variable instead.

@yuanchen8911
Copy link
Member Author

yuanchen8911 commented May 7, 2024 •
edited
Loading

Applied the changes and regenerated the svg file. PTAL

@yuanchen8911
Add an in-cluster example for injection failure
e21466e 
Update svg

Update site/content/en/docs/user/examples/injectfailure/virtual-gpu-node.yaml

Co-authored-by: Shiming Zhang <[email protected]>

Update site/content/en/docs/user/examples/injectfailure/failed-pod.yaml

Co-authored-by: Shiming Zhang <[email protected]>

Update demos

Update
@yuanchen8911
Copy link
Member Author

Does this need to be supplemented with docs for a more complete example?

Add a MD description file?

@wzshiming
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming, yuanchen8911

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 957d154 into kubernetes-sigs:main May 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yibozhuang yibozhuang Awaiting requested review from yibozhuang

@wzshiming wzshiming Awaiting requested review from wzshiming

Assignees

@wzshiming wzshiming

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuanchen8911 @wzshiming @k8s-ci-robot