Record an event when provisioning request fails #3056
Conversation
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: IrvingMg The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
/test all |
|
/cc @mbobrovskyi @trasc |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest-required |
| @@ -302,6 +303,10 @@ func (c *Controller) syncOwnedProvisionRequest(ctx context.Context, wl *kueue.Wo | |||
| } | |||
|
|
|||
| if err := c.client.Create(ctx, req); err != nil { | |||
| ac.Message = fmt.Sprintf("Error creating ProvisioningRequest: %q", requestName) | |||
There was a problem hiding this comment.
Can you include some information about what is the problem in the message?
|
/assign @mbobrovskyi |
| type fakeControllerRuntimeClient struct { | ||
| client.Client | ||
| err error | ||
| } | ||
|
|
||
| func (c *fakeControllerRuntimeClient) WithError(err error) { | ||
| c.err = err | ||
| } | ||
|
|
||
| func (c *fakeControllerRuntimeClient) Create(ctx context.Context, obj client.Object, opts ...client.CreateOption) error { | ||
| if c.err != nil { | ||
| return c.err | ||
| } | ||
|
|
||
| return c.Client.Create(ctx, obj, opts...) | ||
| } |
There was a problem hiding this comment.
Can we use builder.WithInterceptorFuncs(...) instead?
What type of PR is this?
/kind feature
What this PR does / why we need it:
It produces an event when an error during provisioning request creation occurs.
Which issue(s) this PR fixes:
Fixes #3025
Special notes for your reviewer:
Does this PR introduce a user-facing change?