Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the format of the list of images extracted from kubeadm #11741

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix the format of the list of images extracted from kubeadm #11741

wants to merge 1 commit into from
+2 −1

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Nov 24, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
The download role expect 'groups' be a list, in order to properly filter
images.

Which issue(s) this PR fixes:
Fixes #11740

Does this PR introduce a user-facing change?:

Kubeadm images (kube-controller-manager,kube-scheduler,kube-apiserver,kube-proxy) are properly downloaded, including when using the download cache.

@VannTen
Fix the format of the list of images extracted from kubeadm
dc19b45 
The download role expect 'groups' be a list, in order to properly filter
images.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 24, 2024
@VannTen
Copy link
Contributor Author

VannTen commented Nov 24, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 24, 2024
@VannTen
Copy link
Contributor Author

VannTen commented Nov 25, 2024

/retest-failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrFreezeex MrFreezeex Awaiting requested review from MrFreezeex

@tico88612 tico88612 Awaiting requested review from tico88612

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubeadm images not being downloaded
2 participants
@VannTen @k8s-ci-robot