Convert kubernetes-apps to use kubectl directly #11700
Open
+112
−273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
VannTen
force-pushed
the
feat/kubectl_stdin
branch
3 times, most recently
from
603f845
to
593c0f2
Compare
This is expected to be used in the command module this way:
command:
cmd: "{{ kubectl_apply_stdin }}"
stdin: <... rendered manifests > -> using the 'template' lookup plugin
in most cases.
The advantages over the kube plugin module integrated in kubespray
(which this should replace eventually):
- way easier to modify to take advantage of new features (server-side
apply for instance)
- no need for a separate template tasks + checking the result (which can
introduce problem if the first playbook runs encounters an error).
VannTen
force-pushed
the
feat/kubectl_stdin
branch
from
593c0f2
to
07b3bc9
Compare
Note that we're reapplying the RBAC/Sa/Config from coredns which is not strictly necessary, but harmless, when the secondary is enabled.
Not that the Apparmor check result is no longer used since the PSP removal.
VannTen
force-pushed
the
feat/kubectl_stdin
branch
from
07b3bc9
to
1508901
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind design
What this PR does / why we need it:
This design an alternative to the custom kube module for applying manifests, by combining the 'template' lookup plugin with
the
stdinargument of thecommandmodule, and converts the manifests under roles/kubernetes-apps/ansible to make use of it.See first commit for the rationale of that method.
The idea would be to deprecate the
kubemodule and transition existing manifests to this method.Since there is a lot of manifests, there is no need to do eveything at once ; PRs in smaller chunks might be easier to review.
One of the end-goal is to enable server-side apply for CoreDNS (which is converted as part of this PR) to have a proper fix for #10860 and reapply #10617.
This is not done as part of this PR to keep it refactoring only (no behavior change) but will be in a separate one.
Special notes for your reviewer:
Apart from the first commit, this is mostly conversion commits.
Does this PR introduce a user-facing change?:
/label tide/merge-method-merge