🐛 fix: add missing name prefix and namespace to leader-election-role and leader-election-rolebinding #4357
+19
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure this is the best approach but since there are already some hardcoded values in there I suppose it's not a terrible idea either.
The Role and RoleBinding do not have a namespace associated with them when the project is
init
ed. I didn't actually try to deploy this but I believe this would actually fail to apply as is (without the namepace on the Role and RoleBinding - src).I added the expected value that a later instruction is expecting.
There are a few other resources that do not have the prefix either. I can open other PRs to address those individually.