Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 update multi-version with the latest changes and address fixes #4139

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Sep 8, 2024

In this PR we :

  • regenerate the sample using the helper script to ensure that the latest changes are applied
  • we compared the multi-version sample with the cronjob and we ensured that they have the same base
  • we validate the rendered of the docs to ensure that it is done properly. See that by comparing with the book-v2 we could fix a couple of markers to properly render the storage code:
Screenshot 2024-09-08 at 17 38 59

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 8, 2024
@camilamacedo86 camilamacedo86 force-pushed the update-multi-verson-latest branch 4 times, most recently from 1f7162c to 35c0bee Compare September 8, 2024 16:34
@camilamacedo86 camilamacedo86 changed the title WIP 📖 update multi-version with the latest changes and to use the ne… 📖 update multi-version with the latest changes and address fixes Sep 8, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2024
@camilamacedo86
Copy link
Member Author

I will move forward with this one because it is a blocker to allow we move with other initiatives and it mainly does the update of the sample and address required fixes and aligments.

However, if anyone see that it requires changes and improvements please feel free to raise a PR against the code for the mulitversion tutorial sample.

@camilamacedo86 camilamacedo86 merged commit 00a3781 into kubernetes-sigs:master Sep 8, 2024
16 of 20 checks passed
@camilamacedo86 camilamacedo86 deleted the update-multi-verson-latest branch September 8, 2024 16:53
sarthaksarthak9 pushed a commit to sarthaksarthak9/kubebuilder that referenced this pull request Sep 9, 2024
…ernetes-sigs#4139)

📖 update multi-version with the latest changes and to use the new interface for webhooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants