Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong link in ray plugin #4151

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Fix wrong link in ray plugin #4151

merged 1 commit into from
Oct 22, 2024

Conversation

MortalHappiness
Copy link
Contributor

I found that the homepage link for the Ray plugin is incorrect, so I submitted another PR to fix it. Thanks!

@MortalHappiness
Fix wrong link in ray plugin
4a5de9a 
Signed-off-by: Chi-Sheng Liu <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 21, 2024
@ahmetb
Copy link
Member

ahmetb commented Oct 21, 2024

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖

This pull request does not seem to be a straightforward version bump. I'll have a human review this. If we don't respond within a day, feel free to ping us.

Why wasn't this detected as a plugin version bump:

file plugins/ray.yaml is not a straightforward version bump: could not find the old/new version spec in the diff
/kind plugin-update

@k8s-ci-robot k8s-ci-robot added kind/plugin-update Version or manifest updates for existing plugins size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 21, 2024
@ahmetb
Copy link
Member

ahmetb commented Oct 22, 2024

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, MortalHappiness

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit e4081a7 into kubernetes-sigs:master Oct 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskim06 chriskim06 Awaiting requested review from chriskim06

Assignees

@ahmetb ahmetb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/plugin-update Version or manifest updates for existing plugins lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MortalHappiness @ahmetb @k8s-ci-robot