Initial controller implementation #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielvegamyhre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/XL
danielvegamyhre
force-pushed
the
init-controller
branch
2 times, most recently
from
5b28bb0
to
4c71f03
Compare
danielvegamyhre
force-pushed
the
init-controller
branch
from
4c71f03
to
64e0033
Compare
ahg-g
reviewed
Apr 5, 2023
danielvegamyhre
force-pushed
the
init-controller
branch
2 times, most recently
from
cfbfd55
to
727c08d
Compare
danielvegamyhre
force-pushed
the
init-controller
branch
from
727c08d
to
0e34fd3
Compare
ahg-g
reviewed
Apr 5, 2023
ahg-g
reviewed
Apr 6, 2023
ahg-g
reviewed
Apr 6, 2023
danielvegamyhre
force-pushed
the
init-controller
branch
from
bedebc6
to
04819c4
Compare
ahg-g
reviewed
Apr 6, 2023
|
@ahg-g Thanks for the review, and yes I'll submit a PR for some basic integration tests next, then configure a presubmit to run the integration tests. Let me know if the PR looks good now and I'll squash the commits. |
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included in this PR:
Testing:
Note: I looked into adding unit tests for the JobSetReconciler methods themselves, but it seems I would need to possibly fake/mock a Manager to use for creating a unit-testable JobSetReconciler, and I noticed in Kueue there are no reconciler specific unit tests (see here), and the reconciler testing is in the integration tests, so I am planning on doing the same. @ahg-g let me know if you have any thoughts on this.