Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose: add the KubeVela project as a integration #1131

Closed
wants to merge 1 commit into from

Conversation

barnettZQG
Copy link

What type of PR is this?

/kind documentation

What this PR does / why we need it:

The KubeVela community focuses on the practice of application specification, and we agree with the Gateway API in terms of the application gateway rules, so we integrate the specification.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 29, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 29, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: barnettZQG / name: barnettZQG (9d23716)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 29, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @barnettZQG!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 29, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @barnettZQG. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 29, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 29, 2022
@robscott
Copy link
Member

Hey @barnettZQG, thanks for the PR! Trying to understand how this integration works, could it be used with any Gateway API implementation or is it really just tied to Traefik? So far the integrations we have listed can be used with any implementation of the API.

@barnettZQG
Copy link
Author

@robscott thanks for your reply, we provide the user's APIs (the trait in OAM, including http-route, https-route, tcp-route, udp-route) based on Gateway API. The traefik is only a provider, we will integrate other providers that support the Gateway API. For users, they only change the provider name, and no need to change other configurations, when they move the application to other environments.

@robscott
Copy link
Member

robscott commented May 3, 2022

Hey @barnettZQG, I brought this up in today's community meeting, some notes:

  1. We haven't clearly defined what qualifies something to be listed as an integration yet
  2. We want to limit it to integrations that support multiple implementations of the API

I'm going to work on a PR to resolve the first item. It sounds like you're going to add support for additional Gateway API implementations soon, maybe we can just leave this PR open until KubeVela is able to support more than Traefik?

@barnettZQG
Copy link
Author

@robscott OK, we will do it.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: barnettZQG
Once this PR has been reviewed and has the lgtm label, please assign robscott for approval by writing /assign @robscott in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2022
@barnettZQG
Copy link
Author

barnettZQG commented Sep 5, 2022

@robscott Hi, I am sorry to update it after a long time. Currently, we make an addon based on the Gateway API and provide two implementation addons. Traefik and Istio Gateway. Based on the same user-side experience, we could integrate more implementations.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2022
@k8s-ci-robot
Copy link
Contributor

@barnettZQG: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


[KubeVela][kubevela] is a modern software delivery platform that makes deploying and operating applications across today's hybrid, multi-cloud environments easier, faster and more reliable.

KubeVela using the Gateway API provides the standard management ability regarding the application access rules. It currently publishes a [gateway-traits][addon] to provide the user API. There are two implementation addon, [Traefik][traefik] and [Istio gateway][istio]. You can refer to the [installation document][document] to install the KubeVela and enable the gateway-traits addon.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small typo.

Suggested change
KubeVela using the Gateway API provides the standard management ability regarding the application access rules. It currently publishes a [gateway-traits][addon] to provide the user API. There are two implementation addon, [Traefik][traefik] and [Istio gateway][istio]. You can refer to the [installation document][document] to install the KubeVela and enable the gateway-traits addon.
KubeVela using the Gateway API provides the standard management ability regarding the application access rules. It currently publishes a [gateway-traits][addon] to provide the user API. There are two implementation addons, [Traefik][traefik] and [Istio gateway][istio]. You can refer to the [installation document][document] to install the KubeVela and enable the gateway-traits addon.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2023
@Xunzhuo
Copy link
Member

Xunzhuo commented Jan 12, 2023

/lgtm

Need to resolve some conflicts and a rebase.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2023
@k8s-ci-robot
Copy link
Contributor

@barnettZQG: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gateway-api-verify 071f9a5 link true /test pull-gateway-api-verify
pull-gateway-api-test 071f9a5 link true /test pull-gateway-api-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Xunzhuo
Copy link
Member

Xunzhuo commented Jan 12, 2023

/hold after kubevela/catalog#598 gets finished.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2023
@shaneutt
Copy link
Member

/hold after kubevela/catalog#598 gets finished.

I see we're waiting on kubevela/catalog#598 before this PR can move forward. Looking at that issue it appears there is a significant amount of work that needs to be completed. Any thoughts on maybe closing this PR for the moment, so it doesn't have to linger, and then opening a PR when this is ready?

@barnettZQG
Copy link
Author

@shaneutt OK. I will open a new PR after kubevela/catalog#598 is complete.

@barnettZQG barnettZQG closed this Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants