Skip to content

Conversation

@zetxqx
Copy link
Contributor

@zetxqx zetxqx commented Dec 11, 2025

What type of PR is this?

/kind test

What this PR does / why we need it:

This e2e use kustomize to install all the CRDs which is more aligned with what we have in the getting started: https://gateway-api-inference-extension.sigs.k8s.io/guides/getting-started-latest/#install-the-inference-extension-crds

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


@k8s-ci-robot
Copy link
Contributor

@zetxqx: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind test

What this PR does / why we need it:

This e2e use kustomize to install all the CRDs which is more aligned with what we have in the getting started: https://gateway-api-inference-extension.sigs.k8s.io/guides/getting-started-latest/#install-the-inference-extension-crds

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@netlify
Copy link

netlify bot commented Dec 11, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 6ea4fcc
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/693afe4bb0e8340008934af3
😎 Deploy Preview https://deploy-preview-1990--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zetxqx
Once this PR has been reviewed and has the lgtm label, please assign ahg-g for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 11, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 11, 2025
// ApplyYAMLFile reads a file containing YAML (possibly multiple docs)
// and applies each object to the cluster.
func ApplyYAMLFile(testConfig *TestConfig, filePath string) []string {
// return CreateObjsFromKustomize(testConfig, filePath)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this statement a left over from development?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching is a left over from development. removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants