-
Notifications
You must be signed in to change notification settings - Fork 207
test(e2e): use kustomize to install all the crds #1990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@zetxqx: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zetxqx The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6b097c5 to
f907cd0
Compare
test/utils/utils.go
Outdated
| // ApplyYAMLFile reads a file containing YAML (possibly multiple docs) | ||
| // and applies each object to the cluster. | ||
| func ApplyYAMLFile(testConfig *TestConfig, filePath string) []string { | ||
| // return CreateObjsFromKustomize(testConfig, filePath) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this statement a left over from development?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for catching is a left over from development. removed
f907cd0 to
6ea4fcc
Compare
What type of PR is this?
/kind test
What this PR does / why we need it:
This e2e use
kustomizeto install all the CRDs which is more aligned with what we have in the getting started: https://gateway-api-inference-extension.sigs.k8s.io/guides/getting-started-latest/#install-the-inference-extension-crdsWhich issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: