-
Notifications
You must be signed in to change notification settings - Fork 185
Docs: Minor Quickstart Improvements #1760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Daneyon Hansen <[email protected]>
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| ``` | ||
|
|
||
| Confirm that the Gateway was assigned an IP address and reports a `Programmed=True` status: | ||
| 3. Confirm that the Gateway was assigned an IP address and reports a `Programmed=True` status: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does netlify support the md notation of always just using: 1. and letting the MD auto order for you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it does. I can update and test.
| ### Install the Inference Extension CRDs | ||
|
|
||
| ```bash | ||
| kubectl apply -f https://github.com/kubernetes-sigs/gateway-api-inference-extension/releases/download/v1.0.2/v1-manifests.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note to update this to be all manifests, as per the other PR
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Improves the overall UX of the quickstart guides:
rollout statuscommands throughout for early exit if a step fails.kubectl getcommands for ease of copy/paste.What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: