Skip to content

Conversation

@zetxqx
Copy link
Contributor

@zetxqx zetxqx commented Oct 22, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:
The PR 0707d2f#diff-4fff24a24347da2990a6a84ae376c39de10be47f0b08f5f5ac480230dc723ee4 accidentally changed the verification a little bit and it can still pass the conformance test. But that's not what we want to test.
image

Run the test agianst GKE to make sure it still passes

go test -v ./conformance -args -debug -gateway-class gke-l7-regional-external-managed -cleanup-base-resources=false -allow-crds-mismatch=true -run-test InferencePoolResolvedRefsCondition

--- PASS: TestConformance (186.87s)
    --- SKIP: TestConformance/EppUnAvailableFailOpen (0.00s)
    --- SKIP: TestConformance/GatewayFollowingEPPRouting (0.00s)
    --- SKIP: TestConformance/GatewayWeightedAcrossTwoInferencePools (0.00s)
    --- SKIP: TestConformance/HTTPRouteInvalidInferencePoolRef (0.00s)
    --- SKIP: TestConformance/HTTPRouteMultipleGatewaysDifferentPools (0.00s)
    --- SKIP: TestConformance/InferencePoolAccepted (0.00s)
    --- SKIP: TestConformance/InferencePoolHTTPRoutePortValidation (0.00s)
    --- SKIP: TestConformance/InferencePoolInvalidEPPService (0.00s)
    --- SKIP: TestConformance/HTTPRouteMultipleRulesDifferentPools (0.00s)
    --- PASS: TestConformance/InferencePoolResolvedRefsCondition (180.54s)
        --- PASS: TestConformance/InferencePoolResolvedRefsCondition/InferencePool_should_show_Accepted:True_by_parents_and_be_routable_via_multiple_HTTPRoutes (51.25s)
        --- PASS: TestConformance/InferencePoolResolvedRefsCondition/Delete_httproute-for-primary-gw_and_verify_InferencePool_status_and_routing_via_secondary_gw (27.29s)
        --- PASS: TestConformance/InferencePoolResolvedRefsCondition/Delete_httproute-for-secondary-gw_and_verify_InferencePool_has_no_parent_statuses_and_is_not_routable (56.12s)
PASS

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 22, 2025
@netlify
Copy link

netlify bot commented Oct 22, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 991df24
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68f82dccc8fb570007cc3b5f
😎 Deploy Preview https://deploy-preview-1756--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zetxqx
Once this PR has been reviewed and has the lgtm label, please assign danehans for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 22, 2025
@zetxqx zetxqx changed the title Correct the conformance tests. Correct the InferencePoolResolvedRefsCondition conformance tests. Oct 22, 2025
@robscott
Copy link
Member

Thanks @zetxqx!

/lgtm
/cc @danehans

@k8s-ci-robot k8s-ci-robot requested a review from danehans October 22, 2025 15:10
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants