Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws): add soft error #4741

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blanchardma
Copy link

Description

Fixes (again) #4067 because it was partly revert by #3973.

Add the ability to have a soft error when it fails to list resource records sets for zone. For example, if the cause of the error is the throttling of the AWS Route53 API Throttling: Rate exceeded' status code: 400 , it is certainly not helpful if it is not a soft error and flags to improve the situation such as --min-event-sync-interval can not work.

Checklist

  • Unit tests updated
  • End user documentation updated
    -> Both are not needed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 13, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @blanchardma!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 13, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @blanchardma. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 13, 2024
@mloiseleur
Copy link
Contributor

@blanchardma thanks for this. Would you please update the tests accordingly ?

@blanchardma
Copy link
Author

@mloiseleur can you be a bit more specific? Because the other PR #3973 in this direction don't have any and also the one that introduced the softerror #4166.

@szuecs
Copy link
Contributor

szuecs commented Sep 18, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 18, 2024
@szuecs
Copy link
Contributor

szuecs commented Sep 18, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2024
@szuecs
Copy link
Contributor

szuecs commented Sep 18, 2024

@mloiseleur can you be a bit more specific? Because the other PR #3973 in this direction don't have any and also the one that introduced the softerror #4166.

For example #4682

@szuecs
Copy link
Contributor

szuecs commented Sep 24, 2024

@blanchardma #4741 (comment) can you check that?

@mloiseleur

This comment was marked as off-topic.

@k8s-ci-robot
Copy link
Contributor

@mloiseleur: The label(s) /label contributor/waiting-for-feedback cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label contributor/waiting-for-feedback

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mloiseleur

This comment was marked as off-topic.

@k8s-ci-robot
Copy link
Contributor

@mloiseleur: The label(s) /label need-change cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label need-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mloiseleur

This comment was marked as off-topic.

@k8s-ci-robot
Copy link
Contributor

@mloiseleur: The label(s) /label needs-change cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label needs-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mloiseleur
Copy link
Contributor

I tried to add some labels on this PR, without any success 😅 .
Sorry for the noise 🙇 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants