Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add netcup provider #3283

Closed
wants to merge 1 commit into from
Closed

Add netcup provider #3283

wants to merge 1 commit into from

Conversation

mrueg
Copy link
Member

@mrueg mrueg commented Jan 3, 2023 •
edited
Loading

This PR adds support for Netcup CCP https://www.netcup-wiki.de/wiki/CCP_API as a DNS provider.

Tagging @aellwein for visibility.
Discussion started in: aellwein/netcup-dns-api#1

Checklist

  • Unit tests updated (59.5% coverage)
  • End user documentation updated

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mrueg
Once this PR has been reviewed and has the lgtm label, please assign raffo for approval by writing /assign @raffo in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 3, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2023
@mrueg mrueg force-pushed the add-netcup-provider branch 3 times, most recently from 8be37ee to 76e89e4 Compare January 11, 2023 09:21
@mrueg
Copy link
Member Author

mrueg commented Jan 15, 2023

@Raffo @njuettner @seanmalloy @szuecs 👋

I understand that you likely all are busy, is there anything I can further do to get the PR reviewed?

@mrueg @aellwein
Support Netcup as DNS provider
7f81ab4 
Add support for https://www.netcup-wiki.de/wiki/CCP_API via
netcup-dns-api library.

See also: aellwein/netcup-dns-api#1

Co-Authored-By: Alex Ellwein <[email protected]>
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aellwein
Copy link

@mrueg, it seems there is a conflict in go.mod and therefore rebase is needed.

@mrueg
Copy link
Member Author

mrueg commented Mar 27, 2023

@aellwein unfortunately this change won't be integrated, I'm waiting for #3063 so we can have an external provider.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 25, 2023
@mrueg
Copy link
Member Author

mrueg commented Nov 27, 2023

With webhook being available, I've moved this provider over here: https://github.com/mrueg/external-dns-netcup-webhook (currently WIP)

@mrueg mrueg closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner Awaiting requested review from njuettner

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrueg @k8s-ci-robot @aellwein @k8s-triage-robot