Skip to content

Commit

Permalink
fix: add remove default from minimal config
Browse files Browse the repository at this point in the history
  • Loading branch information
AndrewCharlesHay committed Oct 11, 2024
1 parent 438b0bc commit 1e35134
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 24 deletions.
2 changes: 1 addition & 1 deletion pkg/apis/externaldns/types_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ var (
AzureSubscriptionID: "",
CloudflareProxied: false,
CloudflareDNSRecordsPerPage: 100,
CloudflareRegionKey: "earth",
CloudflareRegionKey: "",
CoreDNSPrefix: "/skydns/",
AkamaiServiceConsumerDomain: "",
AkamaiClientToken: "",
Expand Down
23 changes: 0 additions & 23 deletions provider/cloudflare/cloudflare_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1401,29 +1401,6 @@ func TestCloudFlareProvider_Region(t *testing.T) {
}
}

// Will come back to this before merge
// func TestCloudFlareProvider_UpdateDataLocalizationRegionalHostname(t *testing.T) {
// _ = os.Setenv("CF_API_KEY", "xxxxxxxxxxxxxxxxx")
// _ = os.Setenv("CF_API_EMAIL", "[email protected]")
// provider, err := NewCloudFlareProvider(endpoint.NewDomainFilter([]string{"example.com"}), provider.ZoneIDFilter{}, true, false, 50, "us")
// if err != nil {
// t.Fatal(err)
// }

// ctx := context.Background()
// zoneID := "example.com"
// resourceContainer := cloudflare.ZoneIdentifier(zoneID)
// regionalHostnameParam := cloudflare.UpdateDataLocalizationRegionalHostnameParams{
// Hostname: "example",
// RegionKey: "us",
// }

// err = provider.Client.UpdateDataLocalizationRegionalHostname(ctx, resourceContainer, regionalHostnameParam)
// if err != nil {
// t.Errorf("expected no error, but got '%v'", err)
// }
// }

func TestCloudFlareProvider_getUpdateDataLocalizationRegionalHostnameParams(t *testing.T) {
change := &cloudFlareChange{
RegionalHostname: cloudflare.RegionalHostname{
Expand Down

0 comments on commit 1e35134

Please sign in to comment.