-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add idempotence tests #1536
Add idempotence tests #1536
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b40741b
to
3aa25bd
Compare
Similar to container removal, the stop of a container should be a noop if the container has not been found. Found during: kubernetes-sigs/cri-tools#1536 Signed-off-by: Sascha Grunert <[email protected]>
Similar to container removal, the stop of a container should be a noop if the container has not been found. Found during: kubernetes-sigs/cri-tools#1536 Signed-off-by: Sascha Grunert <[email protected]>
Similar to container removal, the stop of a container should be a noop if the container has not been found. Found during: kubernetes-sigs/cri-tools#1536 Signed-off-by: Sascha Grunert <[email protected]>
Similar to container removal, the stop of a container should be a noop if the container has not been found. Found during: kubernetes-sigs/cri-tools#1536 Signed-off-by: Sascha Grunert <[email protected]>
Similar to container removal, the stop of a container should be a noop if the container has not been found. Found during: kubernetes-sigs/cri-tools#1536 Signed-off-by: Sascha Grunert <[email protected]> (cherry picked from commit a97b118)
Similar to container removal, the stop of a container should be a noop if the container has not been found. Found during: kubernetes-sigs/cri-tools#1536 Signed-off-by: Sascha Grunert <[email protected]> (cherry picked from commit a97b118) Signed-off-by: Sascha Grunert <[email protected]>
Similar to container removal, the stop of a container should be a noop if the container has not been found. Found during: kubernetes-sigs/cri-tools#1536 Signed-off-by: Sascha Grunert <[email protected]> (cherry picked from commit a97b118)
6cf605b
to
8ab77e2
Compare
Similar to container removal, the stop of a container should be a noop if the container has not been found. Found during: kubernetes-sigs/cri-tools#1536 Signed-off-by: Sascha Grunert <[email protected]> (cherry picked from commit a97b118) Signed-off-by: Sascha Grunert <[email protected]>
Signed-off-by: Sascha Grunert <[email protected]>
8ab77e2
to
2bb3732
Compare
Green CI. PTAL @kubernetes-sigs/cri-tools-maintainers |
great addition! |
Similar to container removal, the stop of a container should be a noop if the container has not been found. Found during: kubernetes-sigs/cri-tools#1536 Signed-off-by: Sascha Grunert <[email protected]>
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adding tests for RPC idempotence. Right now all runtimes fail them in various cases.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Needs:
StopPodSandbox
RPC idempotent containerd/containerd#10520StopContainer
RPC idempotent containerd/containerd#10521Does this PR introduce a user-facing change?