✨add CodecFactoryOptionsMutators for codecfactory

[Chaunceyctx]

What does this do, and why do we need it?

we have a production scenario:

the CRD field declared in the v1 version of the controller includes field A. However, when we upgrade the v1 controller to v2, field A is removed from the corresponding CRD(we make some changes to this CRD).

So we want the controller to realize this error during data deserialization, so we need to switch the corresponding serializer to strict mode.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Chaunceyctx
Once this PR has been reviewed and has the lgtm label, please assign alvaroaleman for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @Chaunceyctx!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Chaunceyctx. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Chaunceyctx]

/ping gently @vincepri @sbueringer PTAL, thanks a lot :)

[Chaunceyctx]

/ping gently @troy0820

[sbueringer]

What is the user-facing difference in impact between configuring strict here vs. using client.WithFieldValdation to set FieldValidation in the Options structs?

Is it that the latter only affects Create/Update/patch?

[Chaunceyctx]

What is the user-facing difference in impact between configuring strict here vs. using client.WithFieldValdation to set FieldValidation in the Options structs?

Is it that the latter only affects Create/Update/patch?

@sbueringer thanks a lot for feedback :) Yes, FieldValidation will be used in CreateOptions/UpdateOptions/PatchOptions. And these Options will tell apiserver how to select mode of decodeSerializer(strict or not strict), like: https://github.com/kubernetes/kubernetes/blob/6746df77f2376c6bc1fd0de767d2a94e6bd6cec1/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/update.go#L109

So client also need to know how to select mode of decodeSerializer and use strict mode of decodeSerializer to avoid the aforementioned issue.

I will address failed ci job.

[sbueringer]

/ok-to-test

[k8s-ci-robot]

@Chaunceyctx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-controller-runtime-apidiff	6d063ae	link	false	/test pull-controller-runtime-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[Chaunceyctx]

@sbueringer excuse me, could you give me some hints to address this failed ci job? I am a noob for go-apidiff tool