-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 (fix): Enable status subresource in ChaosPod example #2954
base: main
Are you sure you want to change the base?
Conversation
At the moment, even though reconciler works on ChaosPod instance's Status field, the status subresource is not enabled on ChaosPod. This commit adds `// +kubebuilder:subresource:status` marker to allow the generator tool to enable the status subresource on the custom resource definition.
…as to the current scheme and generate manager with this new populated scheme Signed-off-by: Burak Sekili <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: buraksekili The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @buraksekili. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Description
This PR fixes an issue on
examples/crd
controller.Issue
At the moment, even though the reconciler works on ChaosPod instance's Status field, the status subresource is not enabled on ChaosPod. This commit adds
// +kubebuilder:subresource:status
marker to allow the generator tool to enable the status subresource on the custom resource definition.Also, when the example manager starts, it fails due to scheme initialization as the registered types need to be added before starting the manager. Also, it misses
corev1
scheme even though the controller owns Pods.