🌱 Bump conversion-gen to v0.30.0 #10474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
13 tasks
sbueringer
changed the title
|
|
Yup, already on it |
k8s-ci-robot
added
size/XXL
sbueringer
force-pushed
the
pr-conversion-gen-0.30
branch
from
de16e84
to
02335e5
Compare
k8s-ci-robot
added
size/XL
sbueringer
force-pushed
the
pr-conversion-gen-0.30
branch
from
02335e5
to
13ee5b0
Compare
sbueringer
commented
Apr 22, 2024
| @@ -154,3 +155,11 @@ func Convert_v1alpha3_KubeadmControlPlaneSpec_To_v1beta1_KubeadmControlPlaneSpec | |||
| out.MachineTemplate.NodeDrainTimeout = in.NodeDrainTimeout | |||
| return autoConvert_v1alpha3_KubeadmControlPlaneSpec_To_v1beta1_KubeadmControlPlaneSpec(in, out, s) | |||
| } | |||
|
|
|||
| func Convert_v1beta1_KubeadmConfigSpec_To_v1alpha3_KubeadmConfigSpec(in *bootstrapv1.KubeadmConfigSpec, out *bootstrapv1alpha3.KubeadmConfigSpec, s apiconversion.Scope) error { | |||
There was a problem hiding this comment.
This is a workaround for now. Brought up the issue here: kubernetes/code-generator#94
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-conversion-gen-0.30
branch
from
13ee5b0
to
ca09585
Compare
sbueringer
added
area/dependency
|
/lgtm /hold if you want other reviews first |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: db541d08293c54545faaa27b9dc015a3f57237b0
|
k8s-ci-robot
added
the
approved
|
/assign @fabriziopandini |
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
/lgtm Thanks for digging into conversion-gen changes! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi, fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #10026