-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(chart): support configuring dnsConfig #4173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sslavic The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @sslavic! |
Hi @sslavic. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -1,7 +1,7 @@ | |||
apiVersion: v2 | |||
name: aws-load-balancer-controller | |||
description: AWS Load Balancer Controller Helm chart for Kubernetes | |||
version: 1.13.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sslavic You dont need to update the chart version here. We will do it when we release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for review @shraddhabang, I've removed manual chart version change from the PR, PTAL
@sslavic Thank you for your PR. |
Signed-off-by: Stevo Slavic <[email protected]>
/retest |
Issue
#4154
Description
PR extends
aws-load-balancer-controller
Helm chart with support for configuring dnsConfig.PR was tested manually with
helm template
:Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯