-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add wafv2AclArn
field to IngressClassParams
#3961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @mikutas. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
wafv2AclArn
field to IngressClassParams
50d613a
to
a64780e
Compare
/ok-to-test |
/lgtm |
a64780e
to
56a8dd6
Compare
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mikutas The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rebased |
56a8dd6
to
9ccb9af
Compare
9ccb9af
to
a2fbb06
Compare
a2fbb06
to
9cce7f2
Compare
9cce7f2
to
0ca2e1d
Compare
resolved conflicts |
Issue
part of #2311
Description
Add wafv2AclArn field to IngressClassParams.
wafv2-acl-arn
annotation.Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯