-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add parameters to specify resource tracking configuration #3905
Open
oliviassss
wants to merge
4
commits into
kubernetes-sigs:main
Choose a base branch
from
oliviassss:tag-prefix-flag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
labels
Oct 18, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oliviassss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Oct 18, 2024
oliviassss
force-pushed
the
tag-prefix-flag
branch
2 times, most recently
from
October 24, 2024 20:31
929c834
to
8261a45
Compare
oliviassss
changed the title
[WIP]add flag to specify resource prefix for resource tags
add flag to specify resource prefix for resource tags
Oct 24, 2024
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Oct 24, 2024
oliviassss
force-pushed
the
tag-prefix-flag
branch
from
October 24, 2024 20:39
8261a45
to
8b34a18
Compare
oliviassss
force-pushed
the
tag-prefix-flag
branch
from
October 30, 2024 17:33
8b34a18
to
b5df4ba
Compare
k8s-ci-robot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Oct 30, 2024
oliviassss
changed the title
add flag to specify resource prefix for resource tags
add flag to specify resource tracking configuration
Oct 30, 2024
oliviassss
changed the title
add flag to specify resource tracking configuration
add parameters to specify resource tracking configuration
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
This PR adds parameters to specify resource tracking prefix.
clusterTagPrefix
, which iselbv2.k8s.aws
, affects cluster resource tagingressTagPrefix
, which isingress.k8s.aws
, affects ingress resource tagserviceTagPrefix
, which isservice.k8s.aws
, affects service resource tagclusterSgRuleLabelPrefix
, which iselbv2.k8s.aws
, affects worker node sg rules labelThis is mainly for internal project that may fork and specify customized values for these prefixes for resources like ALB, NLB, SG, TG, listener, rule; and customize the label of the SG rules we added to the worker node SG (current label is
elbv2.k8s.aws/targetGroupBinding=shared
). The values in the open source are consistent with current behavior, no existing customer behavior change.Added UTs
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯