Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: eip service annotation - mention subnet discovery #3710

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: eip service annotation - mention subnet discovery #3710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/guide/service/annotations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ on the load balancer.

!!!note
- This configuration is optional, and you can use it to assign static IP addresses to your NLB
- You must specify the same number of eip allocations as load balancer subnets [annotation](#subnets)
- You must specify the same number of eip allocations as load balancer subnets ([annotation](#subnets) or [discovery](../../deploy/subnet_discovery.md))
- NLB must be internet-facing

!!!example
Expand Down
2 changes: 1 addition & 1 deletion pkg/service/model_build_load_balancer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ func (t *defaultModelBuildTask) buildLoadBalancerSubnets(ctx context.Context, sc
)
}

// for internet-facing Load Balancers, the subnets mush have at least 8 available IP addresses;
// for internet-facing Load Balancers, the subnets must have at least 8 available IP addresses;
// for internal Load Balancers, this is only required if private ip address is not assigned
var privateIpv4Addresses []string
ipv4Configured := t.annotationParser.ParseStringSliceAnnotation(annotations.SvcLBSuffixPrivateIpv4Addresses, &privateIpv4Addresses, t.service.Annotations)
Expand Down