Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Commit

Permalink
PR Template (#2206)
Browse files Browse the repository at this point in the history
* PR Template

* update with ideas from upstream k/k

* add documentation requirement to CONTRIBUTING
  • Loading branch information
MHBauer authored and carolynvs committed Jul 17, 2018
1 parent d4b2273 commit 80c2a51
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 0 deletions.
29 changes: 29 additions & 0 deletions .github/PR_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<!-- Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, read our contributor guidelines https://github.com/kubernetes-incubator/service-catalog/blob/master/CONTRIBUTING.md
2. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests
3. See our merge process https://github.com/kubernetes-incubator/service-catalog/blob/master/REVIEWING.md
-->

This PR is a
- [ ] Feature Implementation
- [ ] Bug Fix
- [ ] Documentation

**What this PR does / why we need it**:

**Which issue(s) this PR fixes**
<!-- *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: -->
Fixes #

Please leave this checklist in the PR comment so that maintainers can ensure a good PR.

Merge Checklist:
- [ ] New feature
- [ ] Tests
- [ ] Documentation
- [ ] SVCat CLI flag
- [ ] Server Flag for config
- [ ] Chart changes
- [ ] removing a flag by marking deprecated and hiding to avoid
breaking the chart release and existing clients who provide a
flag that will get an error when they try to update
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ not just a partial solution.
include tests that demonstrates the issue w/o your fix. New features should
include as many testcases, within reason, to cover any variants of use of the
feature.
- All PRs must have appropriate documentation. New features should be
described, and an example of use provided.
- PR authors will need to have CLA on-file with the Linux Foundation before
the PR will be merged.
See Kubernete's [contributing guidelines](https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md) for more information.
Expand Down

0 comments on commit 80c2a51

Please sign in to comment.