Vendor build tools (#2034)

* vendor golint

* use vendored golint in build image

* install az cli from a binary instead of python

.dockerignore

@@ -0,0 +1,2 @@
+*
+!vendor/golang.org

Gopkg.toml

@@ -23,6 +23,7 @@ required = [
   "k8s.io/code-generator/cmd/openapi-gen",
   "k8s.io/gengo/args",
   "github.com/kubernetes/repo-infra/kazel",
+  "golang.org/x/lint/golint",
 ]
 
 # in sync with Kubernetes master (k8s 1.10 future release), but different from Kubernetes etcd version (3.1.10),
@@ -84,5 +85,3 @@ required = [
   non-go = false
   go-tests = false
   unused-packages = false
-
-

Makefile

@@ -197,7 +197,7 @@ $(BINDIR):
 
 .scBuildImage: build/build-image/Dockerfile
 	sed "s/GO_VERSION/$(GO_VERSION)/g" < build/build-image/Dockerfile | \
-	  docker build -t scbuildimage -
+	  docker build -t scbuildimage -f - .
 	touch $@
 
 # Util targets

build/build-image/Dockerfile

@@ -24,17 +24,17 @@ RUN curl -sSL https://github.com/coreos/etcd/releases/download/v3.1.10/etcd-v3.1
     | tar -vxz -C /usr/local/bin --strip=1 etcd-v3.1.10-linux-amd64/etcd
 
 # Install the golint, use this to check our source for niceness
-RUN go get -u github.com/golang/lint/golint
+COPY vendor/golang.org /go/src/golang.org
+RUN go install golang.org/x/lint/golint
 
 # Install the href checker for our md files, update PATH to include it
 RUN git clone https://github.com/duglin/vlinker.git /vlinker
 ENV PATH=$PATH:/vlinker/bin
 
 # Install the azure client, used to publish svcat binaries
-ENV AZCLI_VERSION=2.0.25
-RUN apt-get update && apt-get install -y python-pip && \
-    rm -rf /var/lib/apt/lists/*
-RUN pip install --disable-pip-version-check --no-cache-dir --upgrade cryptography azure-cli==${AZCLI_VERSION}
+ENV AZCLI_VERSION=v0.1.2
+RUN curl -sLo /usr/local/bin/az https://github.com/carolynvs/az-cli/releases/download/$AZCLI_VERSION/az-linux-amd64 && \
+    chmod +x /usr/local/bin/az
 
 # Create the full dir tree that we'll mount our src into when we run the image
 RUN mkdir -p /go/src/github.com/kubernetes-incubator/service-catalog