fix(rules): handle apiserver normalized buckets #1008
Merged
+16
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the work and feedback from #965 and #1006 and brings it into a single PR which:
{le="1"}
and v3{le="1.0"}
histogram bucket formats. This is achieved through the use of regex matchers to make the decimal part optional.I did an ad-hoc benchmark of query latency difference for the
apiserver_request:availability30d
recording rule on a fleet of clusters and saw no significant differences when using the regex matchers in this PR.Supersedes #965 #1006
Fixes #1005