-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templates for Issue creation #3964
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: varodrig <[email protected]>
Signed-off-by: varodrig <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@andreyvelich and @hbelmiro to review thank you and anyone else from the community who wants to provide feedback. " /area model-registry " Created an issue |
/hold |
Signed-off-by: varodrig <[email protected]>
cc @kubeflow/kubeflow-steering-committee @kubeflow/wg-training-leads @kubeflow/wg-pipeline-leads @kubeflow/wg-notebooks-leads @kubeflow/wg-manifests-leads @kubeflow/release-team @kubeflow/wg-data-leads @kubeflow/wg-deployment-leads |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel |
@hbelmiro @andreyvelich @thesuperzapper can you review? Thanks. |
/hold |
Signed-off-by: varodrig <[email protected]>
/hold cancel |
Signed-off-by: varodrig <[email protected]>
Signed-off-by: varodrig <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Since this is affecting all Working groups, please review @hbelmiro @thesuperzapper @rimolive @tarilabs @franciscojavierarceo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the issues should be created and maintain on the same repo the source code lives as software development practice. I think it'll be very confusing to move issues to other repo where the website doesn't belong. What will be the value to community on doing this? it seems to me that it'll add so much confusion. Do we have anyone in the CNCF ecosystem doing managing the website issues this way? For the WG, they could easy triage the issues with the labels we have created in this same repo, where they can select their respective component. Maybe I'm missing what the problem is and what we are trying to solve? Can we move this discussion to an issue as well if needed? it shouldn't block this PR since the PR is already using the labels already defined. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @varodrig I think if we want to have templates for the GH Issues in the Website itself, I suppose it's fine as you are showing here.
My optional suggestion is to make it even more clear, in the body of the template, that this requests are intended to address the Website itself, more explicitly in addition to the title.
Example: make a checkbox at the top with text ~like "I acknowledge I am proposing changes to the website itself, and not for an individual component (which should be raised in the appropriate repo instead)"
For a example impacting MR WG, this issue #3969 is borderline between a doc change request for MR WG (which should be raised in the KF/model-registry repo) and a comment to the website itself -- OP created the issue here using the button on the website, despite we have this per KSC request:
I believe @andreyvelich is cautioning about making clear that GH Issues raised here must be pertaining to the Website, not the individual WG, otherwise would be difficult to triage.
This just what worked for our community before. And from the Working Group point of view the development is going on in their repos, not in the
As I said, we don't have anyone who will triage issues in |
I think maybe we can clarify that if it's a proposal about a functionality itself should be on the component's repo. "Have a proposal about a component's functionality or feedback on a feature? Submit an issue on any of the kubeflow components on their associated repository https://github.com/kubeflow."We also have a new issue type which about support to help the community to find support by posting the problem on the right place. |
@andreyvelich @tarilabs @hbelmiro I'm moving this discussion to a new issue I created Thank you |
Relates to issue #3935
First PR templating issues with the website.
the implementation follows a similar approach as the kubernetes website: https://github.com/kubernetes/website/blob/main/.github/ISSUE_TEMPLATE/bug-report.md
added a support type following practices from the kubernetes website , the main idea is to guide end users on how to proceed when having issues. I created this since I saw some issues created that were asking for support.